Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ElementVirtual work with TagField & inline #49

Closed
wants to merge 1 commit into from
Closed

Make ElementVirtual work with TagField & inline #49

wants to merge 1 commit into from

Conversation

micschk
Copy link
Contributor

@micschk micschk commented Dec 16, 2021

Fixes #5
Fixes #48

@micschk micschk mentioned this pull request Dec 16, 2021
Closed
@wilr
Copy link
Collaborator

wilr commented Apr 25, 2022

@micschk thanks, I assume we need to add TagField as a dependancy. Which version did you expect this to work with ^2.6?

@micschk
Copy link
Contributor Author

micschk commented Aug 25, 2022

@wilr (I think) this issue silverstripe/silverstripe-tagfield#195 and this commit fixing it silverstripe/silverstripe-tagfield@527c5b2. It seems TagField would need a new tag release which includes the above commit for ElementVirtual to work with it (inline).

wilr added a commit that referenced this pull request Apr 18, 2023
@wilr
feat: use TagField for inline linking to elements (fixes #49)
a88567b
@wilr wilr closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make this block work 'inline' Better visual GridField selector for “link existing” UI
2 participants
@micschk @wilr